Skip to content

test: cover review trigger tiering#253

Merged
Koukyosyumei merged 1 commit into
h5i-dev:mainfrom
zerone0x:fix/217-review-tiering-tests
Jul 3, 2026
Merged

test: cover review trigger tiering#253
Koukyosyumei merged 1 commit into
h5i-dev:mainfrom
zerone0x:fix/217-review-tiering-tests

Conversation

@zerone0x

@zerone0x zerone0x commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add pure unit tests for ReviewPoint::quality_triggers() and shape_triggers()
  • cover PR flagging at the quality threshold and verify shape-only scores do not flag
  • document the current review threshold constants in tests

Fixes #217

Verification

  • cargo test review (blocked locally: linker cc not found in cron environment)

@Koukyosyumei Koukyosyumei merged commit 16bc286 into h5i-dev:main Jul 3, 2026
5 checks passed
@Koukyosyumei

Copy link
Copy Markdown
Collaborator

Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for review.rs Quality-vs-Shape tiering

2 participants