Skip to content

[codex] add env profile parsing tests#249

Merged
Koukyosyumei merged 1 commit into
h5i-dev:mainfrom
leemeo3:codex/add-env-profile-parsing-tests
Jul 4, 2026
Merged

[codex] add env profile parsing tests#249
Koukyosyumei merged 1 commit into
h5i-dev:mainfrom
leemeo3:codex/add-env-profile-parsing-tests

Conversation

@leemeo3

@leemeo3 leemeo3 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add sandbox_api coverage for .h5i/env.toml profile parsing: valid defaults, empty-section deny defaults, malformed values, and built-in profile fallback
  • reject unknown keys inside [profile.*] and nested profile tables so profile parsing fails closed instead of silently ignoring typos
  • leave top-level env.toml extensible for existing non-profile tables such as [service.*]

Fixes #213

Validation

  • cargo test --test sandbox_api
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --all-targets
  • cargo test

Notes

Prepared with AI assistance.

@Koukyosyumei Koukyosyumei left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!!

@Koukyosyumei Koukyosyumei merged commit 9774395 into h5i-dev:main Jul 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for .h5i/env.toml profile parsing (fail-closed)

2 participants