Skip to content

feat(validation): implement Standard Schema#964

Closed
sandros94 wants to merge 12 commits into
h3js:mainfrom
sandros94:feat-standard-schema
Closed

feat(validation): implement Standard Schema#964
sandros94 wants to merge 12 commits into
h3js:mainfrom
sandros94:feat-standard-schema

Conversation

@sandros94

@sandros94 sandros94 commented Jan 28, 2025

Copy link
Copy Markdown
Member

Resolves: #963

  • implementation
  • tests (added missing getValidatedRouterParams tests)
  • docs

@sandros94
sandros94 marked this pull request as ready for review January 28, 2025 19:08
@sandros94
sandros94 requested a review from pi0 as a code owner January 28, 2025 19:08
@sandros94

Copy link
Copy Markdown
Member Author

I was also considering an optional argument for readValidatedBody to convert incoming yaml and toml to json using confbox.
Could this be implemented in this PR or a new one? 🤔

@upstars-dmshevchenko

Copy link
Copy Markdown

Cool!
Why not using package? @standard-schema/spec

@sandros94

Copy link
Copy Markdown
Member Author

Cool! Why not using package? @standard-schema/spec

For this use-case it is not strictly needed and as such I personally prefer to keep the deps counter as low as possible 😬

@pi0
pi0 force-pushed the main branch 2 times, most recently from 348028f to a449d79 Compare April 17, 2025 22:19
@pi0

pi0 commented May 30, 2025

Copy link
Copy Markdown
Member

Thanks for PR dear @sandros94 sorry it got stalled with merge conflits.

I have added a smaller subset for basic support in #1068 please feel free to ammend and improve if you have any feedbacks 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Standard Schema validation

3 participants