test/query.test.ts (1)

102-120: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Consider adding a test for the bare * wildcard.

mediaTypeMatches handles accepted === "*" (line 121 in query.ts), but no test covers this case. The */* wildcard is tested, but the bare * variant is not.

🧪 Suggested test

     it("supports the */* wildcard", async () => {
       t.app.query("/any", (event) => requireContentType(event, "*/*"));
       const res = await t.fetch("/any", {
         method: "QUERY",
         body: "x",
         headers: { "content-type": "text/plain" },
       });
       expect(res.status).toBe(200);
     });
+
+    it("supports the bare * wildcard", async () => {
+      t.app.query("/star", (event) => requireContentType(event, "*"));
+      const res = await t.fetch("/star", {
+        method: "QUERY",
+        body: "x",
+        headers: { "content-type": "text/plain" },
+      });
+      expect(res.status).toBe(200);
+    });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/query.test.ts` around lines 102 - 120, Add a test in query.test.ts
covering the bare "*" wildcard path, since mediaTypeMatches explicitly supports
accepted === "*" in query.ts but current coverage only checks "application/*"
and "*/*". Mirror the existing query tests by registering a handler with
requireContentType(event, "*") and asserting a QUERY request with a
representative content-type (for example text/plain) returns 200.

src/utils/query.ts (1)

91-93: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider using k prefix for constants per project convention.

SF_TOKEN_RE and SF_KEY_RE don't follow the k prefix convention used elsewhere in the codebase (e.g., kEventRes, kMalformedURL). As per coding guidelines, symbol constants should use the k prefix (e.g., kNotFound, kHandled).

♻️ Optional refactor

-const SF_TOKEN_RE = /^[A-Za-z*][\w!#$%&'*+.^`|~:/-]*$/;
-const SF_KEY_RE = /^[a-z*][a-z0-9_.*-]*$/;
+const kSfTokenRe = /^[A-Za-z*][\w!#$%&'*+.^`|~:/-]*$/;
+const kSfKeyRe = /^[a-z*][a-z0-9_.*-]*$/;

And update references in serializeMediaType accordingly.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/utils/query.ts` around lines 91 - 93, Rename the constant regex symbols
in query.ts to follow the project’s k-prefix convention by changing SF_TOKEN_RE
and SF_KEY_RE to kSF_TOKEN_RE and kSF_KEY_RE, then update all references in
serializeMediaType and any nearby usage to match the new names. Keep the
behavior unchanged and ensure the new identifiers remain consistent with other
constants like kEventRes and kMalformedURL.

Source: Coding guidelines