fix(response): do not double merge prepared headers in nested error handler#1226
Merged
Conversation
pi0
marked this pull request as ready for review
October 23, 2025 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caught from nuxt ci
When preparing an error response (that is, returning a
Response) itself, we should avoid double merging headers as the first handler itself merges them.Another issue I found is that we are appending prepared headers (intended for a 200 OK response) to the final error response. It seems not best and might leak unwanted headers to error page. We might change that at least for built-in JSON error renderer => #1228