feat: inherit req.context and ServerRequestContext types#1194
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pi0
changed the title
request.context if existsreq.context and ServerRequestContext types
Deploying h3dev with
|
| Latest commit: |
4a08457
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://749c3398.h3dev.pages.dev |
| Branch Preview URL: | https://feat-inherit-ctx.h3dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ServerRequest.contextto be automatically used forH3Event.contextinstead of initiating another ref for broader compatibility.Also now
h3.H3EventContextinheritssrvxServerRequestContextfor sharing types (this is a slight change asRecord<string, any>is changed to ~Record<string, unkown>and untyped context keys areunknown)Note: We do not sync
H3Event.contextback toRequest.contextas this could cause side-effects from library. It happens only from Request => H3Event.