Skip to content

feat: Added label parameter to ui.menu#1663

Merged
mturoci merged 3 commits intoh2oai:masterfrom
Pooja444:issue-1577-menu-label
Nov 3, 2022
Merged

feat: Added label parameter to ui.menu#1663
mturoci merged 3 commits intoh2oai:masterfrom
Pooja444:issue-1577-menu-label

Conversation

@Pooja444
Copy link
Contributor

@Pooja444 Pooja444 commented Oct 8, 2022 •
edited by mturoci
Loading

Github Issue

Closes #1577

Description

Added a 'label' parameter to the UI component of wave. This label will be displayed beside the arrow for the menu dropdown. It will also be clickable, i.e. the dropdown will open on clicking the arrow as well as the label.

Successful local test -

Screen Shot 2022-10-07 at 5 36 00 PM

@Pooja444 Pooja444 requested review from lo5 and mturoci as code owners October 8, 2022 00:34
mturoci
mturoci requested changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Pooja444! A few minor changes. Also do not forget to run make generate after changing the docstrings/attr name. Could you also please add this newly added attribute into our menu.py example and also document it in menu.md?

@Pooja444 Pooja444 requested a review from mturoci October 10, 2022 19:05
@Pooja444
Copy link
Contributor Author

Pooja444 commented Oct 10, 2022 •
edited
Loading

@mturoci thanks for reviewing my PR! I addressed all your review comments, added an example for title in menu.py, and documented it in menu.md. I also ran make generate which automatically added title in a few other files. Please review and let me know if the updates look good.

I also tested it again after the changes -

Successful local test -

Screen Shot 2022-10-10 at 12 09 07 PM

Successful menu.py example run -

Screen Shot 2022-10-10 at 11 52 38 AM

Screen Shot 2022-10-10 at 12 09 50 PM

mturoci
mturoci previously approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pooja444, this is one of the nicest community PRs we received so far! I will label it as hacktoberfest-accepted.

@lo5 can you please have a quick look at the API changes? Thanks!

@mturoci mturoci added the hacktoberfest-accepted PRs that are not yet merged, but shall count towards Hacktoberfest submissions. label Oct 12, 2022
@Pooja444
Copy link
Contributor Author

Pooja444 commented Oct 14, 2022

Thanks @Pooja444, this is one of the nicest community PRs we received so far! I will label it as hacktoberfest-accepted.

@lo5 can you please have a quick look at the API changes? Thanks!

Thanks a lot @mturoci !! 😁

@mturoci mturoci merged commit 6f71c3a into h2oai:master Nov 3, 2022
@mturoci mturoci mentioned this pull request Nov 3, 2022
Closed
@Rmfjd1978
Copy link

Rmfjd1978 commented Nov 7, 2022

This change will be in wich h2o wave version?
bacause i've installed the 0.23.1 and the parameter label is not available on ui.menu

@mturoci
Copy link
Collaborator

mturoci commented Nov 7, 2022

In the next release - 0.24. Currently available in nightly release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mturoci mturoci mturoci left review comments

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees

No one assigned

Labels

hacktoberfest-accepted PRs that are not yet merged, but shall count towards Hacktoberfest submissions.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Title on ui.menu

3 participants

@Pooja444 @Rmfjd1978 @mturoci