Merged
Conversation
Optimize for size, while unrolling the hottest loops
fengjixuchui
added a commit
to fengjixuchui/picotls
that referenced
this pull request
Jun 17, 2020
Merge pull request h2o#310 from h2o/kazuho/fusion
3 tasks
kazuho
added a commit
that referenced
this pull request
Feb 10, 2023
… detect supplied `key` being NULL, but how is that intended to work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fusion is our own AES-GCM crypto, optimized for encrypting short blocks.
Design:
Benchmark:

OpenSSL suffers from ~30% performance penalty when encrypting AEAD blocks of 1440 bytes compared to when encrypting 16KB blocks. With fusion, that overhead is reduced to ~10%. Fusion also succeeds in hiding the crypto overhead of header protection.
To reproduce the results, fusionbench.c is available for measuring the performance of fusion.
openssl speedcommand can be used to measure OpenSSL AEAD performance, though it should be noted that the undocumented-aeadoption have to be used to measure the AEAD performance including the overhead of preprocessing and post-processing (e.g., IV setup, AAD processing, GCM finalization). "openssl 1.1.1g (aead)" shows the numbers with the-aeadoption being set, while "openssl1.1.1g (aesgcm-core)" shows the numbers without.ToDo: