Optimize for size, while unrolling the hottest loops#308
Merged
kazuho merged 3 commits intokazuho/fusionfrom May 7, 2020
Merged
Optimize for size, while unrolling the hottest loops#308kazuho merged 3 commits intokazuho/fusionfrom
kazuho merged 3 commits intokazuho/fusionfrom
Conversation
herumi
added a commit
to herumi/test-picotls
that referenced
this pull request
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attempt of this PR is to reduce the code size while manually unrolling the loops, as sugessted by @herumi.
While manual unrolling does not provide performance improvement on my testbed (Core i5 9400, Ubuntu 19.10), we see comparable performance with less than half the code size.
Object sizes are in bytes, other cells are in seconds (i.e. smaller the better). In addition to the command options listed above,
-DNDEBUG -march-nativewere used in common.