SHUTDOWN COMPACT: parallel map copy (¼ cores default, override with h2.compactThreads) #4273
+35
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| targetMeta.put(MVMap.getMapKey(targetMap.getId()), sourceMeta.get(MVMap.getMapKey(sourceMap.getId()))); | ||
| } | ||
|
|
||
| int poolSize = Integer.getInteger("h2.compactThreads", 1); |
Contributor
There was a problem hiding this comment.
Why would we not want to use half or quarter of the available cores as default instead?
Contributor
Author
There was a problem hiding this comment.
You’re right — defaulting to ¼ of available cores is a good balance.
int poolSize = Integer.getInteger( "h2.compactThreads", Math.max(1, Runtime.getRuntime().availableProcessors() / 4) );
…verride via h2.compactThreads)
Contributor
|
@naive924, Thank You for your contribution! |
naive924
changed the title
naive924
force-pushed
the
feat/compactThreads
branch
from
4673d31 to
6672123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to run map copy in parallel during MVStore.compact().
The change preserves existing logic and metadata handling, only parallelizing the map copy loop.