Code cleanup #4184
Merged
Code cleanup #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzyn
reviewed
Jan 6, 2025
| /** | ||
| * Get the value of the specified user defined variable. This method always | ||
| * returns a value; it returns ValueNull.INSTANCE if the variable doesn't | ||
| * returns a value; it returns ValueNull. INSTANCE if the variable doesn't |
Contributor
There was a problem hiding this comment.
{@code ValueNull.INSTANCE} or {@linkplain ValueNull#INSTANCE} to avoid such formatting.
Contributor
Author
There was a problem hiding this comment.
Yeah, I suppose to read it first 😢
| } | ||
| x = (low + high) >>> 1; | ||
| } | ||
| return -(low + 1); |
Contributor
There was a problem hiding this comment.
I just retested it with JMH on Java 21 / x86_64, ~ is still faster like in older versions of Java.
|
|
||
| @Override | ||
| public int compare(byte[] one, byte[] two) { | ||
| return Arrays.compare(one, two); |
Contributor
There was a problem hiding this comment.
H2 uses Arrays.compareUnsigned() for binary string data types, but octets in SQL and bytes in Java aren't exactly the same thing.
Anyway, it is possible to write a custom data type for MVStore with any comparison rules.
Contributor
Author
There was a problem hiding this comment.
Either way I could care less, it is mostly for benchmark testing and comparison with other stores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposedly there is no functional changes, apart from support for byte[] as keys and Integers as keys / values in MVMap (not used by H2).