Code cleanup around Table.getConstraints()/getIndexes() #4177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzyn
reviewed
Jan 2, 2025
Contributor
katzyn
left a comment
katzyn
left a comment
There was a problem hiding this comment.
What happened in TestCompatibility.testConcurrentAutoIncrement()?
FileStore.acceptChunkOccupancyChanges() threw an assertion error with message 2:
assert !mvStore.isOpen() || chunk != null : chunkId;I think I newer saw such failure in CI tests.
h2/src/main/org/h2/table/Table.java
Outdated
| public ArrayList<Constraint> getConstraints() { | ||
| return constraints; | ||
| public final Iterable<Constraint> getConstraints() { | ||
| return constraints == null ? Collections.emptyList() : constraints; |
Contributor
Author
|
I've never seen it either, but now I realized that it is possible under very unfortunate thread scheduling. Pages within chunk may become dead before that chunk even posted to a chunk map. It's all just speculations, because I still unable to reproduce it for real. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.