Add test coverage for JDK 17 #3718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzyn
reviewed
Jan 28, 2023
Contributor
katzyn
left a comment
katzyn
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
h2/src/tools/org/h2/build/Build.java
Outdated
Comment on lines
1152
to
1156
| String version = System.getProperty("java.specification.version"); | ||
| if (version.startsWith("1.")) { | ||
| version = version.substring(2); | ||
| } | ||
| return Integer.parseInt(version) >= 15; // Nashorn was removed in Java 15 |
Contributor
There was a problem hiding this comment.
You can use getJavaVersion() here.
Contributor
Author
There was a problem hiding this comment.
Thanks, I didn't see that! Done in 687cc0f.
Contributor
|
Builds on Java 11 and Java 17 were cancelled after failure on Java 8. Did it happen due to changes in |
Contributor
|
Please, add |
Contributor
Author
Done in 1b2d113. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we'd like to use H2 on JDK 17, it would be great if it would be officially tested on it. Thus, this PR adds another CI build for JDK 17 (in addition to the ones for JDK 8 and 11). In order to work with JDK 17 bytecode, the test dependency on ASM was updated to 9.4. Since the Nashorn Javascript engine was removed in JDK 15, it's added as another test dependency when the build is running on 15 or later.