fix chunk header size calculation #3648
Conversation
| } | ||
|
|
||
| public String getHeader() { | ||
| return new String(getHeaderBytes(), StandardCharsets.ISO_8859_1); |
There was a problem hiding this comment.
It's just been like that from day 1. It should make zero difference since we are talking lower ASCII characters only.
There was a problem hiding this comment.
StandardCharsets.ISO_8859_1 is the fastest encoding in JVMs with compact strings.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| long delimiterPosition = buff.position() + minLength - 1; | ||
| buff.put(getHeaderBytes()); | ||
| void writeChunkHeader(WriteBuffer buff, int maxLength) { | ||
| long delimiterPosition = buff.position() + maxLength - 1; |
There was a problem hiding this comment.
IntLongMath: Expression of type int may overflow before being assigned to a long
| long delimiterPosition = buff.position() + maxLength - 1; | |
| long delimiterPosition = (long) buff.position() + maxLength - 1; |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
3 participants
Fix #3646