Fix some compatibility issues #3608
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| }) { | ||
| try { | ||
| FilePath p = (FilePath) Class.forName(c).getDeclaredConstructor().newInstance(); | ||
| p = (FilePath) Class.forName(c).getDeclaredConstructor().newInstance(); |
There was a problem hiding this comment.
UnsafeReflectiveConstructionCast: Prefer asSubclass instead of casting the result of newInstance, to detect classes of incorrect type before invoking their constructors.This way, if the class is of the incorrect type,it will throw an exception before invoking its constructor.
| p = (FilePath) Class.forName(c).getDeclaredConstructor().newInstance(); | |
| p = Class.forName(c).asSubclass(FilePath.class).getDeclaredConstructor().newInstance(); |
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
@sonatype-lift ignore
There was a problem hiding this comment.
I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.
1 participant
RUNSCRIPT … FROM_1Xis fixed. Closes Improper FROM_1X implementation corrupts some BLOBs during migration #3604.NULLarguments properly. Closes [MySQL] UNIX_TIMESTAMP should return NULL #3607.FilePathDiskdoesn't use reflection any more. This default implementation is expected to be always available.