Never put read locks into lockSharedSessions and other minor changes #3315

katzyn · 2022-01-01T05:58:26Z

Obscure exclusive and forceLockEvenInMvcc parameters are replaced with single parameter with possible values READ_LOCK, WRITE_LOCK, and EXCLUSIVE_LOCK.
MVTable now handles read locks in consistent way. Previously these locks weren't included into map of shared write locks if and only if lock was acquired immediately without wait loop. In presence of concurrent exclusive session they were incorrectly promoted to write locks after release of that concurrent exclusive lock. Now they are never included into that map, there are no reasons to do it (but they still wait for release of concurrent exclusive lock, of course).
StringUtils.join() is removed and replaced with String.join().
Historical internal incorrect = syntax in ORDER BY is not accepted by the parser any more.
Parameter in ? = CALL syntax is now parsed directly without additional switch over types of tokens.
Parser.parseSelectExpressions() now changes currentSelect only when necessary.

katzyn added 5 commits December 31, 2021 14:37

Use String.join() instead of StringUtils.join()

834ced5

Minor changes in Parser

fa21c28

Don't parse historical internal =index syntax in ORDER BY

498c56d

Replace obscure parameters of Table.lock() with lock type

16f5b53

Never put read locks into lockSharedSessions

572dbfe

katzyn merged commit 7e7d011 into h2database:master Jan 1, 2022

katzyn deleted the misc branch January 1, 2022 07:39

Provide feedback