Repository navigation
Commit cee6529
zstd-safe: make DCtx::try_clone refuse owned state and keep its limits
ZSTD_copyDCtx() is a plain memcpy of every field before inBuff. That range
includes the owning ddictLocal (load_dictionary, ref_prefix,
init_using_dict) and ddictSet (ref_ddict with RefMultipleDDicts) pointers,
so both contexts freed them on drop. It also includes streamStage but not
the stream buffers that go with it, so a clone taken mid-frame resumed on
uninitialized state. Conversely, maxWindowSize (WindowLogMax) and
outBufferMode (StableOutBuffer) live after inBuff, so a clone silently
fell back to the 128 MiB default window limit.
Refuse to clone a context that owns a dictionary, a prefix, a DDict table
or stream buffers (with ZSTD_error_stage_wrong, as the documentation
promises), reset the clone's session after the copy, and carry over the
parameters ZSTD_copyDCtx() leaves behind.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-WVVZMOB8.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-QPS9S9CM.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01MxSMUdwqoQ3qm6UF82MgZD1 parent 53a8a29 commit cee6529
2 files changed
Lines changed: 194 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
92 | 99 | | |
93 | 100 | | |
94 | 101 | | |
| |||
1035 | 1042 | | |
1036 | 1043 | | |
1037 | 1044 | | |
1038 | | - | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
1039 | 1052 | | |
1040 | 1053 | | |
1041 | 1054 | | |
| |||
1064 | 1077 | | |
1065 | 1078 | | |
1066 | 1079 | | |
1067 | | - | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
1068 | 1087 | | |
1069 | 1088 | | |
1070 | 1089 | | |
| |||
1318 | 1337 | | |
1319 | 1338 | | |
1320 | 1339 | | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
1321 | 1343 | | |
1322 | 1344 | | |
1323 | 1345 | | |
| |||
1435 | 1457 | | |
1436 | 1458 | | |
1437 | 1459 | | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
1438 | 1467 | | |
1439 | 1468 | | |
1440 | 1469 | | |
1441 | 1470 | | |
1442 | 1471 | | |
1443 | 1472 | | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
1444 | 1478 | | |
1445 | 1479 | | |
1446 | 1480 | | |
1447 | 1481 | | |
1448 | 1482 | | |
1449 | | - | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
1450 | 1528 | | |
1451 | 1529 | | |
1452 | 1530 | | |
1453 | 1531 | | |
1454 | 1532 | | |
1455 | 1533 | | |
| 1534 | + | |
| 1535 | + | |
| 1536 | + | |
| 1537 | + | |
| 1538 | + | |
1456 | 1539 | | |
1457 | 1540 | | |
1458 | 1541 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
748 | 748 | | |
749 | 749 | | |
750 | 750 | | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
751 | 818 | | |
752 | 819 | | |
753 | 820 | | |
| |||
772 | 839 | | |
773 | 840 | | |
774 | 841 | | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
775 | 883 | | |
776 | 884 | | |
777 | 885 | | |
| |||
0 commit comments