Repository navigation
Commit 9bf1692
Say why the Send and Sync impls hold
Most of these were bare. Two rationales cover nearly all of them: the C
object is an owned heap allocation with nothing thread-local in it, and
everything that mutates it goes through `&mut self`. The dictionaries get
their own note - they are immutable once built, which zstd.h states
outright for ZSTD_CDict - and the thread pool gets one for being designed
to be shared, with its queue under an internal mutex.
Also correct the note next to `CStream`, which claimed it does not
implement Sync. It is an alias for `CCtx`, so it always has.
Comments only, no behaviour change. Raised in the audit appendix of #366;
these are written from the code rather than taken from the report.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01TeZDBS4Uw5kdF77tkJ7cAe1 parent 681bcc3 commit 9bf1692
2 files changed
Lines changed: 37 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
871 | 871 | | |
872 | 872 | | |
873 | 873 | | |
| 874 | + | |
| 875 | + | |
874 | 876 | | |
875 | | - | |
| 877 | + | |
| 878 | + | |
876 | 879 | | |
877 | 880 | | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
878 | 888 | | |
| 889 | + | |
879 | 890 | | |
880 | 891 | | |
881 | 892 | | |
| |||
1285 | 1296 | | |
1286 | 1297 | | |
1287 | 1298 | | |
| 1299 | + | |
1288 | 1300 | | |
1289 | 1301 | | |
| 1302 | + | |
1290 | 1303 | | |
1291 | 1304 | | |
1292 | 1305 | | |
| |||
1385 | 1398 | | |
1386 | 1399 | | |
1387 | 1400 | | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
1388 | 1404 | | |
1389 | 1405 | | |
1390 | 1406 | | |
| |||
1468 | 1484 | | |
1469 | 1485 | | |
1470 | 1486 | | |
| 1487 | + | |
| 1488 | + | |
1471 | 1489 | | |
1472 | 1490 | | |
1473 | 1491 | | |
| |||
1521 | 1539 | | |
1522 | 1540 | | |
1523 | 1541 | | |
| 1542 | + | |
| 1543 | + | |
1524 | 1544 | | |
1525 | 1545 | | |
1526 | 1546 | | |
1527 | 1547 | | |
1528 | 1548 | | |
1529 | 1549 | | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
1530 | 1553 | | |
1531 | 1554 | | |
1532 | 1555 | | |
| |||
1544 | 1567 | | |
1545 | 1568 | | |
1546 | 1569 | | |
1547 | | - | |
| 1570 | + | |
1548 | 1571 | | |
1549 | 1572 | | |
1550 | 1573 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
175 | 177 | | |
176 | 178 | | |
177 | 179 | | |
| 180 | + | |
| 181 | + | |
178 | 182 | | |
179 | 183 | | |
180 | 184 | | |
| |||
259 | 263 | | |
260 | 264 | | |
261 | 265 | | |
| 266 | + | |
| 267 | + | |
262 | 268 | | |
263 | 269 | | |
264 | 270 | | |
| |||
456 | 462 | | |
457 | 463 | | |
458 | 464 | | |
| 465 | + | |
| 466 | + | |
459 | 467 | | |
460 | 468 | | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
461 | 472 | | |
462 | 473 | | |
463 | 474 | | |
| |||
625 | 636 | | |
626 | 637 | | |
627 | 638 | | |
| 639 | + | |
628 | 640 | | |
629 | 641 | | |
630 | 642 | | |
| |||
0 commit comments