Repository navigation
Commit 781ea45
Check dictionary sample sizes with overflow detection
ZDICT_trainFromBuffer() is never told the length of the samples buffer:
the only thing keeping train_from_buffer() and dict::from_continuous()
sound is checking that the sample sizes add up to it. Iterator::sum wraps
when overflow checks are off (release builds), so a list totalling
2^64 + len passed the check and the trainer read past the buffer.
Sum with checked_add at both sites.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-4COHAHJE.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01MxSMUdwqoQ3qm6UF82MgZD1 parent 08ab8ee commit 781ea45
3 files changed
Lines changed: 35 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
191 | 196 | | |
192 | 197 | | |
193 | 198 | | |
| |||
366 | 371 | | |
367 | 372 | | |
368 | 373 | | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
369 | 382 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2684 | 2684 | | |
2685 | 2685 | | |
2686 | 2686 | | |
2687 | | - | |
| 2687 | + | |
| 2688 | + | |
| 2689 | + | |
| 2690 | + | |
| 2691 | + | |
| 2692 | + | |
| 2693 | + | |
| 2694 | + | |
| 2695 | + | |
| 2696 | + | |
2688 | 2697 | | |
2689 | 2698 | | |
2690 | 2699 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
197 | 208 | | |
198 | 209 | | |
199 | 210 | | |
| |||
0 commit comments