Repository navigation
Commit 779d39a
Add fallible constructors for prepared dictionaries
EncoderDictionary::copy/new and DecoderDictionary::copy/new panic when zstd
cannot load the dictionary (ZSTD_createCDict / ZSTD_createDDict return NULL),
for instance a dictionary that starts with the magic number but has a corrupt
header. A service that accepts dictionaries from elsewhere has no way to
reject such input short of catching the panic, while the non-prepared paths
(Compressor/Decompressor::with_dictionary) already return an error.
Add try_copy and try_new, returning io::Result, and document the panic on
the existing constructors. In zstd-safe, add CDict/DDict::
try_create_by_reference next to the existing try_create, and document the
panics there too. The panicking constructors are unchanged.1 parent fc5d2b7 commit 779d39a
3 files changed
Lines changed: 181 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
30 | 38 | | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
34 | 49 | | |
35 | 50 | | |
36 | 51 | | |
37 | 52 | | |
38 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
39 | 64 | | |
40 | 65 | | |
41 | 66 | | |
| |||
46 | 71 | | |
47 | 72 | | |
48 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
49 | 79 | | |
50 | 80 | | |
51 | 81 | | |
52 | 82 | | |
53 | 83 | | |
54 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
55 | 99 | | |
56 | 100 | | |
57 | 101 | | |
| |||
67 | 111 | | |
68 | 112 | | |
69 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
70 | 121 | | |
71 | 122 | | |
72 | 123 | | |
73 | 124 | | |
74 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
75 | 136 | | |
76 | 137 | | |
77 | 138 | | |
| |||
80 | 141 | | |
81 | 142 | | |
82 | 143 | | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
83 | 149 | | |
84 | 150 | | |
85 | 151 | | |
86 | 152 | | |
87 | 153 | | |
88 | 154 | | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
89 | 168 | | |
90 | 169 | | |
91 | 170 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1527 | 1527 | | |
1528 | 1528 | | |
1529 | 1529 | | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
1530 | 1535 | | |
1531 | 1536 | | |
1532 | 1537 | | |
1533 | 1538 | | |
1534 | 1539 | | |
1535 | 1540 | | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
| 1545 | + | |
| 1546 | + | |
| 1547 | + | |
| 1548 | + | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
1536 | 1556 | | |
1537 | 1557 | | |
1538 | 1558 | | |
| |||
1549 | 1569 | | |
1550 | 1570 | | |
1551 | 1571 | | |
1552 | | - | |
1553 | | - | |
1554 | | - | |
1555 | | - | |
| 1572 | + | |
1556 | 1573 | | |
1557 | 1574 | | |
1558 | 1575 | | |
| |||
1608 | 1625 | | |
1609 | 1626 | | |
1610 | 1627 | | |
| 1628 | + | |
| 1629 | + | |
| 1630 | + | |
| 1631 | + | |
| 1632 | + | |
| 1633 | + | |
| 1634 | + | |
1611 | 1635 | | |
1612 | 1636 | | |
1613 | 1637 | | |
1614 | 1638 | | |
1615 | 1639 | | |
| 1640 | + | |
| 1641 | + | |
| 1642 | + | |
| 1643 | + | |
| 1644 | + | |
1616 | 1645 | | |
1617 | 1646 | | |
1618 | 1647 | | |
| |||
1640 | 1669 | | |
1641 | 1670 | | |
1642 | 1671 | | |
| 1672 | + | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
1643 | 1676 | | |
1644 | 1677 | | |
1645 | 1678 | | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
1646 | 1691 | | |
1647 | 1692 | | |
1648 | 1693 | | |
| |||
1657 | 1702 | | |
1658 | 1703 | | |
1659 | 1704 | | |
1660 | | - | |
1661 | | - | |
1662 | | - | |
1663 | | - | |
| 1705 | + | |
1664 | 1706 | | |
1665 | 1707 | | |
1666 | 1708 | | |
| |||
0 commit comments