Repository navigation
Commit 1565618
Check the target, not the host, for MSVC
#353 stopped passing -fvisibility=hidden to cl.exe by testing
cfg!(target_env = "msvc"), which fixed the reported case. But build
scripts are compiled for the machine running them, so that cfg answers
for the host: cross-compiling from a non-MSVC host to a *-windows-msvc
target still hands the gcc-style flag to cl.exe.
Read CARGO_CFG_TARGET_ENV instead, behind a helper shared with the
seekable build in the cmake path, which was already doing this.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01TeZDBS4Uw5kdF77tkJ7cAe1 parent 8315a62 commit 1565618
1 file changed
Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
366 | 366 | | |
367 | 367 | | |
368 | 368 | | |
369 | | - | |
| 369 | + | |
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
| |||
410 | 410 | | |
411 | 411 | | |
412 | 412 | | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
413 | 423 | | |
414 | 424 | | |
415 | 425 | | |
| |||
0 commit comments