Disallow shell history embedding unless explicitly configured#33
Merged
guywaldman merged 5 commits intomainfrom Jul 23, 2024
Merged
Disallow shell history embedding unless explicitly configured#33guywaldman merged 5 commits intomainfrom
guywaldman merged 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
general.access_to_shell_historyconfiguration flag for explicitly allowing access to shell historysearch.allow_remote_llmconfiguration flag for explicitly allowing access to shell history to non-local LLM providerssearch.shell_historyconfiguration for specifying a custom path to a shell history file (added for testing, but may be optionally useful for users none the less)search.index_dirconfiguration for specifying a custom path to a directory which will contain the indexing data and metadata (added for testing, but may be optionally useful for users none the less)Addresses #30