Skip to content

Commit d5f4e5c

Browse files
fix: patch changesets to fix pre-release peer dep major escalation
Patches @changesets/assemble-release-plan to pass includePrerelease to semver.satisfies() when in pre-release mode. Without this, pre-release versions like 1.6.0-beta.0 are incorrectly considered out of range for ^1.5.6, causing all peer dependents to escalate to major versions. This is a known upstream bug (changesets/changesets#960, open since 2022). The patch is applied automatically by pnpm install.
1 parent 91a838f commit d5f4e5c

3 files changed

Lines changed: 55 additions & 3 deletions

File tree

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
diff --git a/dist/changesets-assemble-release-plan.cjs.js b/dist/changesets-assemble-release-plan.cjs.js
2+
index e07ba6e793021b6cfdec898afca517e293386ddb..c3c7c78be51bbc4bf25da83d634f8899afc68bf9 100644
3+
--- a/dist/changesets-assemble-release-plan.cjs.js
4+
+++ b/dist/changesets-assemble-release-plan.cjs.js
5+
@@ -216,7 +216,7 @@ function determineDependents({
6+
onlyUpdatePeerDependentsWhenOutOfRange: config.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH.onlyUpdatePeerDependentsWhenOutOfRange
7+
})) {
8+
type = "major";
9+
- } else if ((!releases.has(dependent) || releases.get(dependent).type === "none") && (config.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH.updateInternalDependents === "always" || !semverSatisfies__default["default"](incrementVersion(nextRelease, preInfo), versionRange))) {
10+
+ } else if ((!releases.has(dependent) || releases.get(dependent).type === "none") && (config.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH.updateInternalDependents === "always" || !semverSatisfies__default["default"](incrementVersion(nextRelease, preInfo), versionRange, preInfo ? { includePrerelease: true } : undefined))) {
11+
switch (depType) {
12+
case "dependencies":
13+
case "optionalDependencies":
14+
@@ -321,7 +321,7 @@ function shouldBumpMajor({
15+
return depType === "peerDependencies" && nextRelease.type !== "none" && nextRelease.type !== "patch" && (
16+
// 1. If onlyUpdatePeerDependentsWhenOutOfRange set to true, bump major if the version is leaving the range.
17+
// 2. If onlyUpdatePeerDependentsWhenOutOfRange set to false, bump major regardless whether or not the version is leaving the range.
18+
- !onlyUpdatePeerDependentsWhenOutOfRange || !semverSatisfies__default["default"](incrementVersion(nextRelease, preInfo), versionRange)) && (
19+
+ !onlyUpdatePeerDependentsWhenOutOfRange || !semverSatisfies__default["default"](incrementVersion(nextRelease, preInfo), versionRange, preInfo ? { includePrerelease: true } : undefined)) && (
20+
// bump major only if the dependent doesn't already has a major release.
21+
!releases.has(dependent) || releases.has(dependent) && releases.get(dependent).type !== "major");
22+
}
23+
diff --git a/dist/changesets-assemble-release-plan.esm.js b/dist/changesets-assemble-release-plan.esm.js
24+
index ea2be567403c4ef94a65f3218ccb683cf5cb4bc1..0994493ff553b1ed856cb54a0db1648f56d550bc 100644
25+
--- a/dist/changesets-assemble-release-plan.esm.js
26+
+++ b/dist/changesets-assemble-release-plan.esm.js
27+
@@ -205,7 +205,7 @@ function determineDependents({
28+
onlyUpdatePeerDependentsWhenOutOfRange: config.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH.onlyUpdatePeerDependentsWhenOutOfRange
29+
})) {
30+
type = "major";
31+
- } else if ((!releases.has(dependent) || releases.get(dependent).type === "none") && (config.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH.updateInternalDependents === "always" || !semverSatisfies(incrementVersion(nextRelease, preInfo), versionRange))) {
32+
+ } else if ((!releases.has(dependent) || releases.get(dependent).type === "none") && (config.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH.updateInternalDependents === "always" || !semverSatisfies(incrementVersion(nextRelease, preInfo), versionRange, preInfo ? { includePrerelease: true } : undefined))) {
33+
switch (depType) {
34+
case "dependencies":
35+
case "optionalDependencies":
36+
@@ -310,7 +310,7 @@ function shouldBumpMajor({
37+
return depType === "peerDependencies" && nextRelease.type !== "none" && nextRelease.type !== "patch" && (
38+
// 1. If onlyUpdatePeerDependentsWhenOutOfRange set to true, bump major if the version is leaving the range.
39+
// 2. If onlyUpdatePeerDependentsWhenOutOfRange set to false, bump major regardless whether or not the version is leaving the range.
40+
- !onlyUpdatePeerDependentsWhenOutOfRange || !semverSatisfies(incrementVersion(nextRelease, preInfo), versionRange)) && (
41+
+ !onlyUpdatePeerDependentsWhenOutOfRange || !semverSatisfies(incrementVersion(nextRelease, preInfo), versionRange, preInfo ? { includePrerelease: true } : undefined)) && (
42+
// bump major only if the dependent doesn't already has a major release.
43+
!releases.has(dependent) || releases.has(dependent) && releases.get(dependent).type !== "major");
44+
}

‎pnpm-lock.yaml‎

Lines changed: 8 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pnpm-workspace.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ onlyBuiltDependencies:
5454
overrides:
5555
axios: <1.14.0
5656

57+
patchedDependencies:
58+
'@changesets/assemble-release-plan': patches/@changesets__assemble-release-plan.patch
59+
5760
trustPolicy: no-downgrade
5861

5962
trustPolicyIgnoreAfter: 43200

0 commit comments

Comments
 (0)