Bug - Leading Whitespace On Stream In#53
Merged
gulrak merged 1 commit intogulrak:masterfrom Mar 4, 2020
Merged
Conversation
Owner
|
Nice catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue where leading whitespace in an input stream buffer causes a
pathto be invalid.To reproduce:
See a compiling example here. This was tested using MSVC 16.4.5 and g++ 9.1.0. In both configurations,
std::filesystembehaves as expected (runstd-fsin the root directory) whereghc::filesystemreturns a path with a leading space and fails to properly parse when handed tostd::ifstream(runalt-fsin the root directory).The fix simply streams in the first character when testing for a quote character. This causes the operation to respect the current
skipwsflag. Usingstd::basic_istream::get()will ignore theskipwsflag and simply read in the first character (if there is leading whitespace, a whitespace character). If theskipwsflag is set in theistream, bothstd::filesystemandghc::filesystemread in the whitespace character and fail the assertion.