Proposal: Performance optimization for Windows#136
Merged
gulrak merged 3 commits intogulrak:masterfrom Oct 23, 2021
Merged
Conversation
Contributor
Author
|
@gulrak, I am sorry to distract you. |
Owner
|
Thank you! I'll look into it this evening and as far as I can see it will be in 1.5.10. - I Needed to delay that release due to time constrains but really plan finishing it over the weekend, as I'm starting to now have a bit more time at my hands again. |
Owner
|
Nice, thank you! My only issue might be the different member marking style in the new helper class, but I can fix that when I wrap up the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::shared_ptrtostd::unique_ptrbecausestd::unique_ptrdoes not use reference counter.std::shared_ptr<void>(for storing handle) to custom unique_handle class becausestd::shared_ptruse reference counter.In all cases, a reference count is not needed, since the stored object exists in a single instance.
Replace
std::shared_ptr<void>tostd::unique_ptris wrong, becausestd::unique_ptrdoesn't call deleter on zero pointer and zero - is valid handle value.