using static_cast instead of old style cast#108
Merged
gulrak merged 1 commit intogulrak:masterfrom Mar 19, 2021
philbucher:patch-1
Merged
using static_cast instead of old style cast#108gulrak merged 1 commit intogulrak:masterfrom philbucher:patch-1
gulrak merged 1 commit intogulrak:masterfrom
philbucher:patch-1
Conversation
This is a warning in GCC when using -Wold-style-cast
Contributor
Author
|
I am not sure if there is a reason for using the old style cast, please check BTW you could consider making this file a #ifdef __clang__
# pragma clang system_header
#elif defined __GNUC__
# pragma GCC system_header
#endifBut then you would no longer see them during development I think |
Owner
|
Hi, thank you for the PR, indeed I didn't want to hide warnings, as I prefer to change to code to avoid them. Those old-style casts are a result of copying code from an old tooling file of mine and I should have replaced them, so thanks for fixing it. |
Contributor
Author
|
cool thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a warning in GCC when using
-Wold-style-cast