You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removed use of the __cpp_lib_string_view macro, because the __cpp_lib_string_view macro requires <version>(C++20) or <string_view> (In the libc++: only since version 8.0: llvm/llvm-project@f56972e)
Added support of legacy std::experimental::string_view (if the std::string_view not found).
Added selector to use a custom, user provided string_view implementation (by defining the GHC_HAS_USER_STRING_VIEW macro and add using custom::basic_string_view into ghc::filesystem namespace).
Maybe the GHC_HAS_USER_STRING_VIEW macro should be renamed?
Thank you for the effort, I really like the idea! Only the removal of __cpp_lib_string_view (that also is required to be delivered by <string> besides <string_view>) is something I rather not prefer, as this solution would force the compilers or their libs down to only the three explicitly handled ones, and my main concern is any conforming compiler should work without explicitly being named when possible (there are more out there than these three, like EDG, or Embarcadero C++). So I can see the need to additionally detect the corner cases (like other code in this project, detecting cases where MSVC does not deliver a usable __cplusplus) to enable more string_view chances, but not the removal of the standard conforming detection. It could be used to also set GHC_HAS_STD_STRING_VIEW to fit to the changes.
(I can not really think of a better name for GHC_HAS_USER_STRING_VIEW, besides maybe GHC_HAS_CUSTOM_STRING_VIEW, but both would be fine.)
As this (and the last) week are very busy job-wise, I wouldn't be able to merge this before weekend anyway.
Thanks again for your PR and support! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gulrak
added
the
available on master
__cpp_lib_string_viewmacro, because the__cpp_lib_string_viewmacro requires<version>(C++20) or<string_view>(In the libc++: only since version 8.0: llvm/llvm-project@f56972e)std::experimental::string_view(if thestd::string_viewnot found).GHC_HAS_USER_STRING_VIEWmacro and addusing custom::basic_string_viewintoghc::filesystem namespace).Maybe the
GHC_HAS_USER_STRING_VIEWmacro should be renamed?