feat: live signal-firing status overlays (Phase 2b)#74
Merged
Conversation
…rols Co-authored-by: Erwin L. <[email protected]>
There was a problem hiding this comment.
Stale comment
Risk: medium. Cursor Bugbot was not present on this PR; CI checks (pre-commit and all platform builds) completed successfully. Approved based on bounded user-facing sim overlay changes with no automated findings requiring human review.
Sent by Cursor Approval Agent: Pull Request Router and Approver
…erlays-2d56 # Conflicts: # CHANGELOG.md # package.json # src/extension.ts # src/preview/BtGraphController.ts Co-authored-by: Erwin L. <[email protected]>
…erlays-2d56 # Conflicts: # CHANGELOG.md Co-authored-by: Erwin L. <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Phase 2b: signal firing — visualize behavior-tree execution live in the graph by driving the exec-core
Simulator(#72, now merged todevel) from the host and overlaying node status.What's included
src/shared/protocol.ts):sim(webview→host:step/reset) andtickUpdate(host→webview: per-node status + blackboard).BtGraphController.ts): owns aSimulatorper document; steps it and broadcaststickUpdate; clears the run (and overlays) on any document edit. Offline outcome model: each leaf is RUNNING for one tick then SUCCESS, so stepping visibly walks the tree. Command-paletteBTView: Simulate: Step One Tick/Resetadded.statusonFlowNodeData;BtNode.tsxrenders a status badge + colored ring (RUNNING pulses);graphContextholds sim state, handlestickUpdate, and exposes step/play/pause/reset (Play auto-steps every 700 ms and halts on SUCCESS/FAILURE); newSimToolbarin the header with a tick counter, root status, and blackboard readout.Walkthrough
btview_signal_firing_simulation_demo.mp4
Stepping/playing the simulation fires status through the tree — amber RUNNING walks down the sequence and nodes latch green SUCCESS; Reset clears overlays.
Sequence mid-run: first child SUCCESS, second RUNNING
Run complete: all nodes SUCCESS
Testing
npm run check-typesnpm run lintnpm run compilenpm run test:unit— 70 passedTo show artifacts inline, enable in settings.