Skip to content

feat: live signal-firing status overlays (Phase 2b)#74

Merged
guilyx merged 3 commits into
develfrom
cursor/sim-signal-overlays-2d56
Jul 4, 2026
Merged

feat: live signal-firing status overlays (Phase 2b)#74
guilyx merged 3 commits into
develfrom
cursor/sim-signal-overlays-2d56

Conversation

@guilyx

@guilyx guilyx commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

Phase 2b: signal firing — visualize behavior-tree execution live in the graph by driving the exec-core Simulator (#72, now merged to devel) from the host and overlaying node status.

Rebased onto devel; conflicts resolved (CHANGELOG.md, package.json, extension.ts, BtGraphController.ts — the sim commands now sit alongside the verifyTree command from #75). Targets devel directly.

What's included

  • Protocol (src/shared/protocol.ts): sim (webview→host: step/reset) and tickUpdate (host→webview: per-node status + blackboard).
  • Host (BtGraphController.ts): owns a Simulator per document; steps it and broadcasts tickUpdate; clears the run (and overlays) on any document edit. Offline outcome model: each leaf is RUNNING for one tick then SUCCESS, so stepping visibly walks the tree. Command-palette BTView: Simulate: Step One Tick / Reset added.
  • Webview: status on FlowNodeData; BtNode.tsx renders a status badge + colored ring (RUNNING pulses); graphContext holds sim state, handles tickUpdate, and exposes step/play/pause/reset (Play auto-steps every 700 ms and halts on SUCCESS/FAILURE); new SimToolbar in the header with a tick counter, root status, and blackboard readout.

Walkthrough

btview_signal_firing_simulation_demo.mp4

Stepping/playing the simulation fires status through the tree — amber RUNNING walks down the sequence and nodes latch green SUCCESS; Reset clears overlays.

Sequence mid-run: first child SUCCESS, second RUNNING
Run complete: all nodes SUCCESS

Testing

  • npm run check-types
  • npm run lint
  • npm run compile
  • npm run test:unit — 70 passed
  • ✅ Manual GUI demo (video above), verified via video review.

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

@cursor cursor Bot marked this pull request as ready for review July 2, 2026 21:35
cursor[bot]
cursor Bot previously approved these changes Jul 2, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Cursor Bugbot was not present on this PR; CI checks (pre-commit and all platform builds) completed successfully. Approved based on bounded user-facing sim overlay changes with no automated findings requiring human review.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

Base automatically changed from cursor/exec-tick-core-2d56 to devel July 2, 2026 21:51
@guilyx guilyx dismissed cursor[bot]’s stale review July 2, 2026 21:51

The base branch was changed.

…erlays-2d56

# Conflicts:
#	CHANGELOG.md
#	package.json
#	src/extension.ts
#	src/preview/BtGraphController.ts

Co-authored-by: Erwin L. <[email protected]>
cursor[bot]
cursor Bot previously approved these changes Jul 2, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Cursor Bugbot was not present on this PR; no automated findings require human review. Approved based on bounded sim overlay changes across protocol, host, and webview layers.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

…erlays-2d56

# Conflicts:
#	CHANGELOG.md

Co-authored-by: Erwin L. <[email protected]>
@cursor cursor Bot dismissed their stale review via 1f26f4f July 4, 2026 11:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Cursor Bugbot was not present on this PR; no automated findings require human review. Approved based on bounded sim overlay changes across protocol, host, and webview layers.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@guilyx guilyx merged commit 604c211 into devel Jul 4, 2026
6 checks passed
@guilyx guilyx deleted the cursor/sim-signal-overlays-2d56 branch July 4, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants