Merged
Conversation
jlp-craigmorten
changed the title
Closed
jlp-craigmorten
commented
Feb 29, 2024
* some aria-live test cases are failing and need looking at
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Attempts to resolve #49.
Partially resolves #2.
Details
Updates to dependencies + import syntax to enable ESM environment support for the likes of web-test-runner (*caveated in that still need some bundler logic for upstream dependencies).
This required an updated to
aria-queryvia resolutions (hopefully can be removed with release of v10 of@testing-library/dom, see testing-library/dom-testing-library#1269) which means we also now get some updated WAI-ARIA 1.2 roles which is somewhat a breaking change.CheckList