Feat: adds proxy agent for NVDA installation request#32
Feat: adds proxy agent for NVDA installation request#32cmorten merged 2 commits intoguidepup:mainfrom
Conversation
|
It would be good to add an e2e test / example to https://github.com/guidepup/setup/blob/main/.github/workflows/test.yml where we set a value for the env var and see a successful installation |
That said, such a test would be quite involved afaik, requiring to write a local test proxy server… https://www.npmjs.com/package/https-proxy-agent is very battle tested so don’t expect any issues, there’s just no guarantee this won’t be accidentally regressed as is. Let’s go with it for now and come back for it if required. |
Issue
No issue found.
Details
Until now it was not possible to download NVDA on windows when using a proxy.
CheckList