refactor: consume promises from fs rather than fs/promises to support downstream ESM usage#78
Merged
jlp-craigmorten merged 1 commit intomainfrom Feb 29, 2024
Merged
Conversation
…upport downstream ESM usage
Contributor
Author
|
@scottnath has this captured the change you've suggested correctly? |
This was referenced Feb 29, 2024
|
@jlp-craigmorten this changed worked great. Steps I took to test:
so this is a big 👍 from me - thanks for the fast turnaround! |
diegohaz
referenced
this pull request
in ariakit/ariakit
Mar 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@guidepup/guidepup](https://togithub.com/guidepup/guidepup) | [`0.22.2` -> `0.22.3`](https://renovatebot.com/diffs/npm/@guidepup%2fguidepup/0.22.2/0.22.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>guidepup/guidepup (@​guidepup/guidepup)</summary> ### [`v0.22.3`](https://togithub.com/guidepup/guidepup/releases/tag/0.22.3) [Compare Source](https://togithub.com/guidepup/guidepup/compare/0.22.2...0.22.3) #### What's Changed - refactor: consume `promises` from `fs` rather than `fs/promises` to support downstream ESM usage by [@​jlp-craigmorten](https://togithub.com/jlp-craigmorten) in [https://github.com/guidepup/guidepup/pull/78](https://togithub.com/guidepup/guidepup/pull/78) - thanks to [@​scottnath](https://togithub.com/scottnath) for proposed change **Full Changelog**: guidepup/guidepup@0.22.2...0.22.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #77 .
Details
Replaces usage of
fs/promiseswith thepromisesnamed export fromfsto support downstream ESM usage.Scouted some minor/patch dependency upgrades.
CheckList