Skip to content

Heartbeat cleanup and fixes#374

Merged
n8fr8 merged 2 commits intoguardianproject:masterfrom
lukeswitz:hb-notification-mods
Feb 28, 2019
Merged

Heartbeat cleanup and fixes#374
n8fr8 merged 2 commits intoguardianproject:masterfrom
lukeswitz:hb-notification-mods

Conversation

@lukeswitz
Copy link
Collaborator

@lukeswitz lukeswitz commented Feb 17, 2019

  • remove throwable for testing: shouldn't be caught
  • remove log message that contained a potentially null string
  • increment only on sent message to avoid false negative

- remove throwable: shouldn't be caught!
- remove log message that contained a potentially null string

Co-authored-by: Root Down <[email protected]>
@lukeswitz lukeswitz changed the title HB: ensure explanation is sent first, fix possible crash Heartbeat cleanup and fixes Feb 19, 2019
@n8fr8 n8fr8 merged commit b3b6f9a into guardianproject:master Feb 28, 2019
@lukeswitz lukeswitz deleted the hb-notification-mods branch March 6, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants