Skip to content

Add heartbeat notifications#270

Merged
n8fr8 merged 10 commits intoguardianproject:masterfrom
lukeswitz:dev2
Apr 5, 2018
Merged

Add heartbeat notifications#270
n8fr8 merged 10 commits intoguardianproject:masterfrom
lukeswitz:dev2

Conversation

@lukeswitz
Copy link
Collaborator

@lukeswitz lukeswitz commented Mar 18, 2018

Feature Description:

Updated

Fills feature request from #54

  • Option to send beating heart emoji while the monitor is active.
  • Timer settings: minimum 1 minute and defaults to 5.
  • Sent to the saved phone number via Signal as: 💓
  • Used JNI compatible strings to avoid parsing errors on lower Android versions instead of adding the EmojiCompat dependency

@n8fr8
Copy link
Member

n8fr8 commented Mar 19, 2018

Excellent, so happy to see this work underway!

@n8fr8 n8fr8 added this to the Current Sprint milestone Mar 19, 2018
@n8fr8 n8fr8 self-assigned this Mar 19, 2018
@n8fr8
Copy link
Member

n8fr8 commented Mar 20, 2018

In quick testing, it seems to send the heartbeat when the app is open, not just when there is an active monitoring session. Is that the case? I will look through the code more, but just curious what your intention was.

@lukeswitz
Copy link
Collaborator Author

Thanks, that was the intent, to make sure the app is still alive. I didn't hook into any service/activity; when testing, the leaked handler would cease alerts but keep monitoring locally. Your help & thoughts on where/when to monitor are very much appreciated : )

@n8fr8
Copy link
Member

n8fr8 commented Mar 20, 2018

In talking with some of our most committed users, they sometimes have incidents where they forget whether they have activated Haven or not. To them the heartbeat, was a way to confirm that active monitoring was engaged, and if it stopped, to know that someone had turned it off. I would tie this all into the Monitor Service to enable that.

@lukeswitz
Copy link
Collaborator Author

On it.

@n8fr8
Copy link
Member

n8fr8 commented Mar 25, 2018

Cool. Will review soon!

@n8fr8 n8fr8 merged commit aa649f4 into guardianproject:master Apr 5, 2018
@lukeswitz lukeswitz deleted the dev2 branch April 7, 2018 23:16
@lukeswitz lukeswitz mentioned this pull request May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants