Update placeholder to use min-height#9008
Merged
sophie-macmillan merged 1 commit intomainfrom Oct 4, 2023
Merged
Conversation
…Stats doesn't break as the placeholder is too small
abeddow91
approved these changes
Oct 4, 2023
DanielCliftonGuardian
approved these changes
Oct 4, 2023
|
Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the placeholder component to use min-height rather than height. This is so things rendered on the serverside (like getMatchStats) don't break if their content is taller than the placeholder height.
Closes #9006
Screenshots