Skip to content

Revert "Islands can no longer be “client-side only”"#8975

Merged
sophie-macmillan merged 1 commit intomainfrom
revert-8948-oj/islands/never-client-side-only
Oct 3, 2023
Merged

Revert "Islands can no longer be “client-side only”"#8975
sophie-macmillan merged 1 commit intomainfrom
revert-8948-oj/islands/never-client-side-only

Conversation

@cemms1
Copy link
Copy Markdown
Contributor

@cemms1 cemms1 commented Oct 3, 2023

Reverts #8948 as live blogs in preview were failing to render properly due to

ReferenceError: window is not defined
 at getKey (/home/dotcom-rendering/rendering/dist/webpack:/@guardian/dotcom-rendering/src/components/Liveness.importable.tsx
…

@sophie-macmillan sophie-macmillan added the run_chromatic Runs chromatic when label is applied label Oct 3, 2023
@cemms1 cemms1 marked this pull request as ready for review October 3, 2023 10:11
@cemms1 cemms1 requested a review from a team as a code owner October 3, 2023 10:11
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 3, 2023

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@sophie-macmillan sophie-macmillan merged commit 368310c into main Oct 3, 2023
@sophie-macmillan sophie-macmillan deleted the revert-8948-oj/islands/never-client-side-only branch October 3, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering run_chromatic Runs chromatic when label is applied

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants