Fix Spacefinder timeout hit with interactives#11077
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: 0 B Total Size: 761 kB ℹ️ View Unchanged
|
mxdvl
approved these changes
Apr 4, 2024
Contributor
mxdvl
left a comment
mxdvl
left a comment
There was a problem hiding this comment.
This looks good to me.
We might want to set the same timeout for the internals of whenIdle. What about 500 in both cases? This can be done as a follow-up to keep changes atomic.
Contributor
Author
Yes we talked about that! Sorry for forgetting to make that change but I agree with you it is better to have it in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR fixes the Commercial logger message 'Spacefinder timeout hit' by replacing
visiblewithidleafter confirming with @mxdvl from WebEx that it is safe to do so.We have a
5000timeout for Spacefinder and as you can see from the 'Before' screenshot all different ad sizes that will be inserted by Spacefinder exceeds that time.The change has been tested locally and in CODE with these articles https://www.theguardian.com/artanddesign/2024/mar/19/damien-hirst-formaldehyde-animal-works-dated-to-1990s-were-made-in-2017 (Get in touch) and https://www.theguardian.com/society/2024/mar/20/young-people-becoming-less-happy-than-older-generations-research-shows (chart).
Why?
Spacefinder will be able to make decisions about where to place ads without the timeout.
Screenshots