fix(sudo): Simplify sudo password application condition

guanguans · guanguans · commit 80bfc3f999a3 · 2025-12-03T13:30:59.000+08:00
- Remove unnecessary check for PHP SAPI in shouldApplySudoPassword method.
- Ensure the sudo password applies correctly on Unix systems.
- This change makes the logic clearer and more straightforward for future maintenance.

Signed-off-by: guanguans &lt;ityaozm@gmail.com&gt;
diff --git a/composer.json b/composer.json
@@ -49,7 +49,7 @@
         "composer/composer": "^2.9",
         "ergebnis/composer-normalize": "^2.48",
         "ergebnis/license": "^2.7",
-        "ergebnis/php-cs-fixer-config": "^6.56",
+        "ergebnis/php-cs-fixer-config": "^6.57",
         "ergebnis/rector-rules": "^1.7",
         "guanguans/monorepo-builder-worker": "^2.1",
         "illuminate/support": "^10.49 || ^11.0 || ^12.0",
@@ -84,7 +84,7 @@
         "tomasvotruba/class-leak": "^2.1",
         "tomasvotruba/cognitive-complexity": "^1.0",
         "tomasvotruba/type-coverage": "^2.0",
-        "yamadashy/phpstan-friendly-formatter": "^1.2"
+        "yamadashy/phpstan-friendly-formatter": "^1.3"
     },
     "conflict": {
         "pestphp/pest": "^4.0",
diff --git a/src/Concerns/HasSudoPassword.php b/src/Concerns/HasSudoPassword.php
@@ -38,6 +38,6 @@ public function withSudoPassword(
 
     protected function shouldApplySudoPassword(): bool
     {
-        return $this->sudoPassword && OsHelper::isUnix() && !\in_array(\PHP_SAPI, ['cli', 'cli-server', 'phpdbg', 'embed'], true);
+        return $this->sudoPassword && OsHelper::isUnix();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,6 @@ public function withSudoPassword(`
`38`	`38`
`39`	`39`	`protected function shouldApplySudoPassword(): bool`
`40`	`40`	`{`
`41`		`- return $this->sudoPassword && OsHelper::isUnix() && !\in_array(\PHP_SAPI, ['cli', 'cli-server', 'phpdbg', 'embed'], true);`
	`41`	`+ return $this->sudoPassword && OsHelper::isUnix();`
`42`	`42`	`}`
`43`	`43`	`}`