Skip to content

upgrade repo to golang 1.21.4#163

Merged
ceschae merged 10 commits into
masterfrom
caitlin/fix-ci
Jan 21, 2025
Merged

upgrade repo to golang 1.21.4#163
ceschae merged 10 commits into
masterfrom
caitlin/fix-ci

Conversation

@ceschae

@ceschae ceschae commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes #162

CI has been breaking since #142, this fixes that issue.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes

Updated golang version for repo to v1.21.4.

@ceschae ceschae requested a review from brikis98 as a code owner January 17, 2025 18:45
@ceschae ceschae changed the title upgrade repo to golang 1.21.4 [WIP] upgrade repo to golang 1.21.4 Jan 17, 2025
@ceschae

ceschae commented Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

ugh i got too excited and missed that the tests failed. hold please

@ceschae ceschae changed the title [WIP] upgrade repo to golang 1.21.4 upgrade repo to golang 1.21.4 Jan 17, 2025
@ceschae

ceschae commented Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

ok, fixed the test step, needed a new docker image. this is ready for review!

@ceschae ceschae merged commit 5e5ca07 into master Jan 21, 2025
@ceschae ceschae deleted the caitlin/fix-ci branch January 21, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failed in CI

2 participants