Skip to content

Conversation

@vladikoff
Copy link
Member

No description provided.

@vladikoff vladikoff merged commit 2805dc3 into main Jan 29, 2023
"findup-sync": "~0.3.0",
"glob": "~7.1.6",
"findup-sync": "~5.0.0",
"glob": "~8.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladikoff just FYI this bump could wreak havoc for Windows users since backslashes need to be escaped in v8.x.

"license": "MIT",
"engines": {
"node": ">=8"
"node": ">=16"
Copy link

@newhouse newhouse Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I think that if you're following Semver, this is a breaking change, requiring a major version bump. Yet this was published in a minor version bump (1.5.X => 1.6.0).

This means that packages (like spectaql) that had something like this in their dependencies will now break for installations on Node < 16:

{
  ...
  "dependencies": {
    ...
    "grunt": "^1.5.3",
    ...
  }
  ...
}

@vladikoff @XhmikosR

UPDATE: already noticed in #1751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants