A21 update: Do not use default service config on transient resolver failure#188
Merged
markdroth merged 2 commits intogrpc:masterfrom Jun 23, 2020
Merged
A21 update: Do not use default service config on transient resolver failure#188markdroth merged 2 commits intogrpc:masterfrom
markdroth merged 2 commits intogrpc:masterfrom
Conversation
ejona86
approved these changes
Jun 23, 2020
A21-service-config-error-handling.md
Outdated
| resolution attempt as having failed (e.g., for a polling-based resolver, | ||
| it should retry the query after appropriate backoff). In other words, | ||
| the channel will remain in state TRANSIENT_FAILURE until a valid | ||
| service config is received. |
Member
Author
There was a problem hiding this comment.
Changed to "until the resolver returns a valid response".
dfawley
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we've discussed, this is necessary to support the new ConfigSelector API (the details of which will be described in Doug's forthcoming gRFC about the RouteAction design).