Objective-C: update macOS and iOS versions to match grpc core config#553
Objective-C: update macOS and iOS versions to match grpc core config#553
Conversation
| compilers: [Node v4+] | ||
| - language: Objective-C | ||
| os: [Mac OS X 10.11+, iOS 7.0+] | ||
| os: [macOS 10.10+, iOS 9.0+] |
There was a problem hiding this comment.
@veblush @jtattermusch @yulin-liang: notice how this used to be 10.11+ (rather than 10.9+). Hence, this PR downgrades the macOS version constraint to match the min version specified by grpc/grpc#24282. Just pointing this out to ensure that it is ok.
There was a problem hiding this comment.
This is weird to me because it's different from ones in the gRPC repository. I think having 10.10+ would be fine since our CI test are using that version.
There was a problem hiding this comment.
This is weird to me because it's different from ones in the gRPC repository
Just let me know which versions (for macOS and iOS) you'd like to see in the docs, and I'll make the changes. I just used 10.10+ because that is what grpc/grpc#24282 seemed to suggest.
There was a problem hiding this comment.
10.10+ sounds reasonable to me!
chalin
force-pushed
the
chalin-macos-ios-vers-2020-12-03
branch
3 times, most recently
from
b137b8e to
c008830
Compare
Match verions of grpc/grpc#24282
chalin
force-pushed
the
chalin-macos-ios-vers-2020-12-03
branch
from
c008830 to
08009ed
Compare
|
Thanks for the review @veblush |
2 participants
Match verions of grpc/grpc#24282:
@veblush @yulin-liang