Add removeListener and missing metadata event types#874
Merged
stanley-cheung merged 1 commit intogrpc:masterfrom Jun 29, 2020
danielthank:add-remove-listener-types
Merged
Add removeListener and missing metadata event types#874stanley-cheung merged 1 commit intogrpc:masterfrom danielthank:add-remove-listener-types
stanley-cheung merged 1 commit intogrpc:masterfrom
danielthank:add-remove-listener-types
Conversation
|
|
danielthank
changed the title
stanley-cheung
approved these changes
Jun 29, 2020
Collaborator
stanley-cheung
left a comment
stanley-cheung
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #873
removeListener, which was introduced in Allow multiple .on() callbacks and fix issue with non-OK status #847on('metadata')event types