Use regular enums for compatibility with TypeScript 5.9+#1507
Merged
sampajano merged 1 commit intogrpc:masterfrom Sep 11, 2025
Merged
Use regular enums for compatibility with TypeScript 5.9+#1507sampajano merged 1 commit intogrpc:masterfrom
sampajano merged 1 commit intogrpc:masterfrom
Conversation
…ity with TypeScript 5.9+
There was a problem hiding this comment.
Pull Request Overview
Updates TypeScript enum generation to use regular enum instead of const enum for compatibility with TypeScript 5.9+ which has verbatimModuleSyntax enabled by default.
- Replace
const enumwithenumin TypeScript declaration file generation - Add explanatory comments documenting the TypeScript compatibility rationale
- Apply changes to both regular enums and oneof case enums
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nnnnoel
approved these changes
Sep 11, 2025
Contributor
nnnnoel
left a comment
nnnnoel
left a comment
There was a problem hiding this comment.
Thanks for mention, I forgot long times about my PR changes.
Looks fine and It has no breaking changes.
Collaborator
Author
|
@nnnnoel Thanks for taking a look and confirming! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates TypeScript enum generation to use regular
enuminstead ofconst enumfor compatibility with TypeScript 5.9+ which hasverbatimModuleSyntaxenabled by default.This is a partial rollback of #1463 — Typescript 5.9+ has
verbatimModuleSyntaxby default, so #1463 no longer compiles by default.@nnnnoel @SidStraw FYI :)
Fixes #1506