Bazel bzlmod support for grpc-web.#1456
Conversation
Updates the bazel-based build of grpc-web to use bzlmod. The WORKSPACE file is retained for now, but it should probably be deleted since it should be unused.
sampajano
left a comment
There was a problem hiding this comment.
@gonzojive Thanks so much for helping with modernizing our build system!!
There are some build failures though (log, could you help take a look please?
Thanks!!
…ailure and protobuf version
|
Would someone on the gprc-web team be interested in being the owner for the grpc-web module in the central registry? I can update https://github.com/bazelbuild/bazel-central-registry/pull/2541/files#diff-75ca774261b28f5a230b37542dc98c9611065b2ae99c7fec5430d164e8db5301 accordingly. I think the release binaries will also need to be updated to include a zip of the source that has a guaranteed checksum (unlike github's automatic source archives). |
Aha thanks for asking! I'm not familiar with the system and not sure what the maintenance work entails.. But would be happy to help look into maintaining it for future releases once it's already been established (thanks for your PR!) and there's a clear steps to follow for keeping it up-to-date 😃 |
https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md has the responsibilities of a maintainer:
There's no need to commit to any of that to submit this PR, though. |
Oh ok!! Thanks for clarifying! Will merge it now! 😊 |
sampajano
left a comment
There was a problem hiding this comment.
Thanks a ton for the change! 😃
Aha and just noticed the maintainer responsibilities! Thanks for linking them! Yeah I think i'll be happy to be the maintainer of the Bazel module (given my role :)). And I'll look into how to update the version when we make new releases. Thanks a lot for the contribution! |
* Bazel bzlmod support for grpc-web. Updates the bazel-based build of grpc-web to use bzlmod. The WORKSPACE file is retained for now, but it should probably be deleted since it should be unused. * Delete WORKSPACE files. * bazel mod tidy * MODULE.bazel fixups * Update version to 1.6.0.rc1 in MODULE.bazel * Update module and dockerfile in response to pr comments about build failure and protobuf version * Fix lint issue with MODULE.bazel
|
@sampajano could you cut a release? It's been 24 commits and over a year since the last one. 1.5.0...master Still waiting on this getting into the Bazel Central Registry. |
|
@alexeagle Hi.. Apologize for the delays! Sorry I was occupied with other work and not able to make progress here. This year we're getting some new help on this project, so we're definitely going to start making progress here, and cutting a new release is first priority! Will definitely aim to cut one soon! And will update here once we did! Thanks for your patience! |
|
@alexeagle FYI - 2.0.0 is released! :) Thank you for your (great) patience! :) |
|
Awesome, thank you! I hope engaging with the community at gRPConf helped inspire the team :) |
|
@alexeagle You're welcome! Oh wow nice.. I in fact missed gRPCConf.. But glad to hear that you had a positive engagement there! 😊 |
Update the bazel-based build of grpc-web to use bzlmod. Delete the WORKSPACE file since it is unused.
Output of
bazel mod graph:fixes #1457