Update ES6 .d.ts imports with comment about corresponding proto import path#1330
Merged
sampajano merged 2 commits intogrpc:masterfrom Oct 5, 2023
Merged
Update ES6 .d.ts imports with comment about corresponding proto import path#1330sampajano merged 2 commits intogrpc:masterfrom
sampajano merged 2 commits intogrpc:masterfrom
Conversation
gonzojive
force-pushed
the
dts-import-comments
branch
from
45a2725 to
c6d8e17
Compare
…t path. grpc#1313 updated the code generator to print a `proto import: "foo/bar.proto"` suffix for each import statement for the generated gRPC-web client code. This commit updates ensures the .d.ts file output by grpc-web contains the same type of comments.
gonzojive
force-pushed
the
dts-import-comments
branch
from
c6d8e17 to
f432fc6
Compare
sampajano
approved these changes
Oct 3, 2023
Collaborator
sampajano
left a comment
sampajano
left a comment
There was a problem hiding this comment.
Thanks so much for the change!
Sorry for the delay too — not sure why this slipped through my list!
Contributor
Author
|
Thanks. I just merged in the latest changes. I think @sampajano will need to trigger the tests and complete the merge. |
Collaborator
@gonzojive Yes will do! Thanks again for the change! |
gonzojive
added a commit
to gonzojive/rules_ts_proto
that referenced
this pull request
Oct 7, 2023
grpc/grpc-web#1330 was merged, so there's no longer a need to depend on a fork.
gonzojive
added a commit
to gonzojive/rules_ts_proto
that referenced
this pull request
Oct 7, 2023
1. Update repository dependency to point to grpc/grpc-web. grpc/grpc-web#1330 was merged, so there's no longer a need to depend on a fork. 2. Add a test of the grpc-web functionality and require the grpc-web node module. 3. Ensure all rewritten imports include the ".mjs" suffix. It was previously omitted for some imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1313 updated the code generator to print a
// proto import: "foo/bar.proto"suffix for each import statement for the generated gRPC-web client code. This commit updates ensures the .d.ts file output by grpc-web contains the same type of comments.