Update envoy version to 1.22 (with config updates)#1222
Update envoy version to 1.22 (with config updates)#1222sampajano merged 2 commits intogrpc:masterfrom tomk9:master
Conversation
|
|
tomk9
changed the title
|
@tomk9 Thanks so much for the change!! Interestingly, didn't find anything mentioning about a "breaking change" in Envoy 1.22 change log.. But it did mention a few things about "typed configuration" and "filter".. :) Could it be a bug on Envoy side? ============================ Aha found this PR: envoyproxy/envoy#20397 It's said to be "strongly recommended" but not required.. but i guess in that case we should adopt it anyways.. 😄 |
| - name: envoy.filters.http.grpc_web | ||
| - name: envoy.filters.http.cors | ||
| - name: envoy.filters.http.router | ||
| - name: envoy.filters.http.grpc_web |
There was a problem hiding this comment.
just curious - does the name still matter now?
There was a problem hiding this comment.
I've checked. Looks like the name doesn't matter anymore.
There was a problem hiding this comment.
Oh i see! Good to know.. Thanks for checking! :)
sampajano
left a comment
sampajano
left a comment
There was a problem hiding this comment.
Thanks so much for helping here! The change looks awesome!! Much appreciated! 😃
| - name: envoy.filters.http.router | ||
| - name: envoy.filters.http.grpc_web | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.grpc_web.v3.GrpcWeb |
There was a problem hiding this comment.
curious - how did you compose this string? :)
i can see extensions.filters.http.grpc_web.v3.GrpcWeb being mentioned on Envoy doc, but what about the type.googleapis.com (maybe it's by convention or "just works"😂) ? 😃
There was a problem hiding this comment.
There was a problem hiding this comment.
Aha ok! Thanks for explaining! :)
| http_filters: | ||
| - name: envoy.grpc_web | ||
| - name: envoy.router | ||
| - name: listener_0 |
There was a problem hiding this comment.
Thanks for bringing the tutorial up-to-date and fixing the formatting too! 😃
sampajano
changed the title
sampajano
changed the title
3 participants
#1220