Add missing exports from RpcError and add test.#1166
Merged
sampajano merged 1 commit intogrpc:masterfrom Nov 12, 2021
Merged
Conversation
sampajano
changed the title
sampajano
force-pushed
the
1-rpcerror-export
branch
from
c96bc8b to
45d34d9
Compare
sampajano
force-pushed
the
1-rpcerror-export
branch
from
45d34d9 to
e138e49
Compare
stanley-cheung
approved these changes
Nov 11, 2021
Collaborator
stanley-cheung
left a comment
stanley-cheung
left a comment
There was a problem hiding this comment.
LGTM, very subtle!
sampajano
changed the title
RpcError and add test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements #1164 to ensure the properties of
RpcErrorare exported as well, and add tests.(btw even without the
@exportannotation these 2 fields are exported today, but that's somewhat by accident -- it's due to them being referred by other classed rather than guaranteed.)