Remove Bazel in Javascript toolchain#1138
Conversation
stanley-cheung
left a comment
stanley-cheung
left a comment
There was a problem hiding this comment.
Thanks for bringing this home. We are that much closer to being able to sync now!
|
@Yannic FYI about this PR. We were having trouble (#1082) syncing code between our internal code base with Github here because @sampajano helped us migrate to be using Protractor to run the jsunit tests (#1137) instead of relying on bazel. Hence a lot of those closure bazel rules are no longer needed. Since you have contributed a lot to this area in the past so we'd like to get your attention on this. Thank you so much contributing! And just to clarify, we will still be using bazel for other purposes in this repo (the cpp generator, etc). We only migrated away the piece where we were using bazel to run the closure jsunit tests away. Thanks! |
|
@Yannic Yeah thanks so much for contributions in the past.. I can see it's quite a lot of work.. And sorry for deleting it.. (But at least the code will be remembered forever by Github just in case we might need it one day in the future :P) |
sampajano
changed the title
sampajano
changed the title
sampajano
changed the title
3 participants
Summary
closure_js_librarytargets for they're no longer used for neither release or testing.closure_grpc_web_libraryandgrpc_web_toolchain, for they depend on rules_closure, and hence an older version of Closure than what's used for release and testing.