Key changes:

• Removed dependency on Bazel / rules_closure for Closure JsUnit tests in favor of google-closure-deps and Protractor.

  • This allow us the direct use use most up-to-date version of Closure Library (v.s. indirectly used through rules_closure), and unblock code sync and new releases.
    • Also ensures tests are ran on the same version of Closure as release (which was not before).
  • Protractor setup uses generated test HTML files, and is HEAVILY inspired by FirebaseUi (mainly just Dockerizing their solution) :)

• Optimized Test flows

  • Restructured Dockerfile layouts and test scripts so that unit tests runs earlier and much faster!
    • e.g. when user makes a javascript changes, reruns will fail in as early as 10 seconds (on jsunit failures) and at most in ~60 seconds (on mocha test failures), compared to 4+ minutes as before ! (on 2019 MacbookPro)
  • npm test in packages/grpc-web now runs both JsUnit tests on top of Mocha tests.

• Optimized Dockerfiles

  • Removed common Docker images (saves disk space) and revamped prereqs to use multistage build.
    • Avoids the possibility code from previous git clone to be accidentally in local builds
  • Optimized prereqs for faster build
    • Reduced build targets so prereqs build time is down from 5+ minutes to <3 minutes (on 2019 MacbookPro)
    • Optimized build sequence so larger / less frequently changed targets are built earlier to best leverage the Docker build cache.

Other (small) changes:

• Fix small flake in interop test where it sometimes times out at 500ms (updated timeout to 1 second)
  • .. and updated mocha unit tests timeout to 10 seconds
• Cleaned up echo example Makefile to ignore testing files (rather than removing then adding them back)
• Created .dockerignore to avoid build failures when local node_modules/ are present
• Deleted streambodyclientreadablestream.js since it’s not used and doesn’t build.

Follow-up:

• Clean up remaining closure_js_library usages and our bazel rules.