Bump Bazel version -> 4.1.0 and Protobuf version -> 3.17.3#1115
Merged
stanley-cheung merged 1 commit intogrpc:masterfrom Aug 5, 2021
Merged
Bump Bazel version -> 4.1.0 and Protobuf version -> 3.17.3#1115stanley-cheung merged 1 commit intogrpc:masterfrom
stanley-cheung merged 1 commit intogrpc:masterfrom
Conversation
21cde5c to
f9bee02
Compare
f9bee02 to
461bf2e
Compare
stanley-cheung
approved these changes
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel -> 4.1.0 (Reducing memory-related crash on Mac)
Similar Bazel crashes to what's reported here (github) or here (stackoverflow) was seen while building the
prereqsimage on macOS/Docker (16-inch intel mbp):The reason is that Bazel will crash under memory pressure. And bumping Bazel version to 4.1.0 fixes it on my Macbook (2019 16-inch mbp) for default Docker on Macsetup (uses 2GB memory).
Although,
./scripts/run_basic_tests.shwould still crash with the same error, which is only fixable after bumping the runtime memory option (e.g. to 4GB) in Docker for Mac settings .(Also big thanks @stanley-cheung for helping with the debugging :))
Protobuf
Updating Protobuf too because Bazel 4.0+ demands Protobuf 3.13+ (see bazelbuild/bazel#12887 (comment)).